Bump clap from 3.2.25 to 4.4.12 and MSRV from 1.60.0 to 1.70.0 #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files
|
rustworthy
force-pushed
the
chore/update-deps
branch
from
b9d8dd5 to
8c63144
Compare
jonhoo
reviewed
Dec 17, 2023
.github/workflows/check.yml
Outdated
| @@ -89,7 +89,7 @@ jobs: | |||
| # https://docs.github.com/en/actions/learn-github-actions/contexts#context-availability | |||
| strategy: | |||
| matrix: | |||
| msrv: [1.57.0] | |||
| msrv: [1.70.0] | |||
There was a problem hiding this comment.
Why this large MSRV bump? That's pretty significant (and recent). Is it required by anything we depend on?
Merged
|
I think many of the changes in this can now go away since the various CI fixes I've landed on As for the clap MSRV bump, that's unfortunate, but I guess we'll take it. After all, people can still install with an older MSRV, they just need an MSRV-aware resolve. |
This was referenced Jan 3, 2024
rustworthy
changed the title
|
I wanted to adjust the clap code slightly, so ended up committing this directly in 2c728b1 so we didn't need to go back and forth another time :) |
|
Released in 0.12.2 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move from clap@3 to clap@4 and set msrv to 1.70
This change is